Benchmark MarkerAttribute #84

New issue

Closed

opened 2026-10-01 19:52:05 +02:00 by c.fahner · 1 comment

c.fahner commented

2026-10-01 19:52:05 +02:00

Owner

The method ::isMarked() for the MarkerAttribute trait is used quite frequently and inside loops (eg. Schema::fromClass()). The fastest way to check should be benchmarked and applied:

foreach ($reflector->getAttributes(static::class) as $_) { return true; }
return \count($reflector->getAttributes(static::class) > 0;
return isset($reflector->getAttributes(static::class)[0]);
return !empty($reflector->getAttributes(static::class)[0]);
???

The method `::isMarked()` for the `MarkerAttribute` trait is used quite frequently and inside loops (eg. `Schema::fromClass()`). The fastest way to check should be benchmarked and applied: * `foreach ($reflector->getAttributes(static::class) as $_) { return true; }` * `return \count($reflector->getAttributes(static::class) > 0;` * `return isset($reflector->getAttributes(static::class)[0]);` * `return !empty($reflector->getAttributes(static::class)[0]);` * ???

c.fahner added the

Kind/Enhancement

label

2026-10-01 19:52:05 +02:00

c.fahner added this to the v0.2 milestone

2026-10-19 18:10:34 +02:00

c.fahner commented

2026-10-19 18:57:12 +02:00

Author

Owner

Only the foreach variant is marginally slower. The bottleneck seems to be the call to getAttributes().

Only the foreach variant is marginally slower. The bottleneck seems to be the call to `getAttributes()`.