Open ended type system #61

New issue

Closed

opened 2026-09-17 07:34:08 +02:00 by c.fahner · 0 comments

c.fahner commented

2026-09-17 07:34:08 +02:00

Owner

Currently the type system only allows types that reduce to one of the types described by the StorageClass enum. This is quite an inflexible system and has the potential to break any time a type must be added. It's also bad at denoting hierarchies.

The Type::serialize() method should be changed to allow a mixed return type, and the TypeInfo utility should only report types that are not mixed, null or DNF. Meaning that Type implementations must still explicitly override the return type hint of the serialize() method. The StorageClass enum should also be removed (see #60).

Additionally the Update statements that deal with adding/setting data must be changed to allow mixed.

Implementations may reject types they don't recognize, but for conformance they must pass the "basic types" test (tracked via slendium/ocd-conformance-tests#6). The basic types to support would be DateTimeInterface, BackedEnum, Blob, array (to enable compound types stored as JSON in SQL databases), string, float, int and bool.

For the DateTimeInterface specifically, support must be added to the relevant Predicate\Expr types that deal with equality/comparison. The Predicate\DocumentShape utility must be expanded with the following methods (which should also be documented at the top of the class):

before(DateTimeInterface)
onOrBefore(DateTimeInterface)
after(DateTimeInterface)
onOrAfter(DateTimeInterface)

Issues #37 and #4 are now obsolete.

Update 2026-09-20: Provide type implementations for the missing basic types: enumerations, date/times and arrays (which will default to generic maps).

Currently the type system only allows types that reduce to one of the types described by the `StorageClass` enum. This is quite an inflexible system and has the potential to break any time a type must be added. It's also bad at denoting hierarchies. The `Type::serialize()` method should be changed to allow a `mixed` return type, and the `TypeInfo` utility should only report types that are not `mixed`, `null` or DNF. Meaning that `Type` implementations must still explicitly override the return type hint of the `serialize()` method. The `StorageClass` enum should also be removed (see #60). Additionally the `Update` statements that deal with adding/setting data must be changed to allow `mixed`. Implementations may reject types they don't recognize, but for conformance they must pass the "basic types" test (tracked via slendium/ocd-conformance-tests#6). The basic types to support would be `DateTimeInterface`, `BackedEnum`, `Blob`, `array` (to enable compound types stored as JSON in SQL databases), `string`, `float`, `int` and `bool`. For the `DateTimeInterface` specifically, support must be added to the relevant `Predicate\Expr` types that deal with equality/comparison. The `Predicate\DocumentShape` utility must be expanded with the following methods (which should also be documented at the top of the class): * `before(DateTimeInterface)` * `onOrBefore(DateTimeInterface)` * `after(DateTimeInterface)` * `onOrAfter(DateTimeInterface)` Issues #37 and #4 are now obsolete. Update 2026-09-20: Provide type implementations for the missing basic types: enumerations, date/times and arrays (which will default to generic maps).

c.fahner added this to the v0.2 milestone

2026-09-17 07:34:08 +02:00

c.fahner added the

Compat/Breaking

label

2026-09-17 07:34:08 +02:00

c.fahner added a new dependency

2026-09-17 07:34:55 +02:00

#60 Remove StorageClass and type checking predicates

c.fahner referenced this issue

2026-09-17 07:36:00 +02:00

Remove StorageClass and type checking predicates #60