Inserting documents #11

New issue

Closed

opened 2026-08-05 17:14:22 +02:00 by c.fahner · 1 comment

c.fahner commented

2026-08-05 17:14:22 +02:00

Owner

The design of Collection::startInsert() is not yet complete.

The insert command should accept any ArrayAcces&Countable&Traversable where field names are non-empty-string and values must be one of the values allowed by Type::serialize() (this must be documented with the Collection::startInsert() method).

The design of `Collection::startInsert()` is not yet complete. The insert command should accept any `ArrayAcces&Countable&Traversable` where field names are `non-empty-string` and values must be one of the values allowed by `Type::serialize()` (this must be documented with the Collection::startInsert() method).

c.fahner added this to the v0.1 milestone

2026-08-05 17:14:22 +02:00

c.fahner added the

Kind/Research

label

2026-08-05 17:14:22 +02:00

c.fahner referenced this issue

2026-08-05 17:24:13 +02:00

Data manipulation #3

c.fahner added a new dependency

2026-08-05 17:24:54 +02:00

#3 Data manipulation

c.fahner commented

2026-08-17 17:22:58 +02:00

Author

Owner

The insert command requires a non-empty-list of documents as an empty list always suggests a mistake. A list with more than one document automatically implies a bulk insertion.

The list always has to be given upfront. Allowing documents to be added to the command after creating it but before executing it allows the user to create an invalid state (an empty list) which would require runtime checking. This invalid state should be prevented by design.

I see no uses cases for addition of documents after the command has been created. The command should be created on the condition that there is at least one document to insert.

The insert command requires a `non-empty-list` of documents as an empty list always suggests a mistake. A list with more than one document automatically implies a bulk insertion. The list always has to be given upfront. Allowing documents to be added to the command after creating it but before executing it allows the user to create an invalid state (an empty list) which would require runtime checking. This invalid state should be prevented by design. I see no uses cases for addition of documents after the command has been created. The command should be created on the condition that there is at least one document to insert.

c.fahner closed this issue

2026-08-17 17:22:58 +02:00

c.fahner added spent time

2026-08-17 17:24:57 +02:00

20 minutes