slendium/http
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

IpAddress::fromString improvements #9

New issue
Closed
opened 2026-04-27 17:55:06 +02:00 by c.fahner · 1 comment
c.fahner commented 2026-04-27 17:55:06 +02:00
Owner
Copy link

Finding while working on slendium/http-superglobals#1: the SocketAddress interface explicitly expects an Ipv4Address|Ipv6Address while IpAddress::fromString() returns only the generic IpAddress type. This means type guards would have to be added every time this method interacts with a SocketAddress, adding unnecessary work. Additionally the fromString methods on both Ipv4Address, Ipv6Address and IpAddress should include Exception as part of their return types to enforce handling all possible cases.

This issue changes IpAddress::fromString() to return Ipv4Address|Ipv6Address|Exception. Likewise with the ipv4 and ipv6 variants of this method.

Finding while working on slendium/http-superglobals#1: the `SocketAddress` interface explicitly expects an `Ipv4Address|Ipv6Address` while `IpAddress::fromString()` returns only the generic `IpAddress` type. This means type guards would have to be added every time this method interacts with a `SocketAddress`, adding unnecessary work. Additionally the `fromString` methods on both `Ipv4Address`, `Ipv6Address` and `IpAddress` should include `Exception` as part of their return types to enforce handling all possible cases. This issue changes `IpAddress::fromString()` to return `Ipv4Address|Ipv6Address|Exception`. Likewise with the ipv4 and ipv6 variants of this method.
c.fahner added this to the v0.2 milestone 2026-04-27 17:55:06 +02:00
c.fahner commented 2026-04-30 06:35:52 +02:00
Author
Owner
Copy link

SocketAddress is not an interface, but the method should be changed nonetheless.

`SocketAddress` is not an interface, but the method should be changed nonetheless.
c.fahner referenced this issue from a commit 2026-04-30 06:47:09 +02:00
Closes #9
c.fahner stopped working 2026-04-30 06:50:01 +02:00
14 minutes 5 seconds
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
v0.2.0
v0.1.0
Labels
Clear labels   
Compat/Breaking
Breaking change that won't be backward compatible

  
Kind/Bug
Something is not working

  
Kind/Documentation
Documentation changes

  
Kind/Enhancement
Improve existing functionality

  
Kind/Feature
New functionality

  
Kind/Security
This is security issue

  
Kind/Testing
Issue or pull request related to testing

  
Priority
Critical
 The priority is critical

  
Priority
High
 The priority is high

  
Priority
Low
 The priority is low

  
Priority
Medium
 The priority is medium

  
Reviewed
Confirmed
 Issue has been confirmed

  
Reviewed
Duplicate
 This issue or pull request already exists

  
Reviewed
Invalid
 Invalid issue

  
Reviewed
Won't Fix
 This issue won't be fixed

  
Status
Abandoned
 Somebody has started to work on this but abandoned work

  
Status
Blocked
 Something is blocking this issue or pull request

  
Status
Need More Info
 Feedback is required to reproduce issue or to continue work

No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No milestone
v0.2
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Total time spent: 14 minutes 5 seconds
c.fahner
14 minutes 5 seconds
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
slendium/http#9
No description provided.